Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ManyManyThrough cannot mismatch Versioning between join class and related class" #282

Closed
kinglozzer opened this issue Jan 21, 2019 · 3 comments

Comments

@kinglozzer
Copy link
Collaborator

https://github.com/symbiote/silverstripe-gridfieldextensions/blob/3.2.1/src/GridFieldOrderableRows.php#L604-L609, introduced in #260

I don’t see any reason for this exception to exist - if we’re dealing with an MMTL, we’re updating the sort on the join record and not touching the related record at all. Whether the related record is versioned or not doesn’t matter here, as we’re not inspecting or updating it. If I remove the exception, everything works as expected.

cc @NightJar, do you remember why this was added? 😁

@NightJar
Copy link
Contributor

NightJar commented Jan 21, 2019

Short answer: Because versioning does my head in.
Long answer: Let me get back to you... ;p

I'm pretty sure there was a reason, but it may not be as valid as I thought due to the short answer here 😉
I'll need to regain context, and I'm a bit busy for that yak shave just now sorry!

@kinglozzer
Copy link
Collaborator Author

I’ve prepared PR #283 for when you get the chance :D

@NightJar
Copy link
Contributor

Cool, I'll look later too.

Long story short is that I believe it'll be to do with user expectations, rather than what is actually possible.

@NightJar NightJar self-assigned this Feb 11, 2019
robbieaverill added a commit that referenced this issue Apr 4, 2019
…d-flames

FIX: Remove unnecessary "version mismatch" restriction (fixes #282)
@dnsl48 dnsl48 closed this as completed in 600a39e Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants