You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don’t see any reason for this exception to exist - if we’re dealing with an MMTL, we’re updating the sort on the join record and not touching the related record at all. Whether the related record is versioned or not doesn’t matter here, as we’re not inspecting or updating it. If I remove the exception, everything works as expected.
cc @NightJar, do you remember why this was added? 😁
The text was updated successfully, but these errors were encountered:
Short answer: Because versioning does my head in.
Long answer: Let me get back to you... ;p
I'm pretty sure there was a reason, but it may not be as valid as I thought due to the short answer here 😉
I'll need to regain context, and I'm a bit busy for that yak shave just now sorry!
kinglozzer
added a commit
to kinglozzer/silverstripe-gridfieldextensions
that referenced
this issue
Jan 22, 2019
https://github.com/symbiote/silverstripe-gridfieldextensions/blob/3.2.1/src/GridFieldOrderableRows.php#L604-L609, introduced in #260
I don’t see any reason for this exception to exist - if we’re dealing with an MMTL, we’re updating the sort on the join record and not touching the related record at all. Whether the related record is versioned or not doesn’t matter here, as we’re not inspecting or updating it. If I remove the exception, everything works as expected.
cc @NightJar, do you remember why this was added? 😁
The text was updated successfully, but these errors were encountered: