Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Remove unnecessary "version mismatch" restriction (fixes #282) #283

Merged
merged 1 commit into from
Apr 4, 2019
Merged

FIX: Remove unnecessary "version mismatch" restriction (fixes #282) #283

merged 1 commit into from
Apr 4, 2019

Conversation

kinglozzer
Copy link
Collaborator

Fixes #282

@kinglozzer kinglozzer mentioned this pull request Jan 22, 2019
Closed
@robbieaverill
Copy link
Contributor

We can fix those test failures by either using recipe-cms instead of recipe-core, or by locking a specific versioned constraint - in the past I've just changed the recipe =)

NightJar
NightJar reviewed Jan 22, 2019
View reviewed changes
Copy link
Contributor

@NightJar NightJar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think simply cutting this code out will leave more cases than intended open to the unexpected, but will have a more thorough review later.
In the least I'd expect the through object to mirror the versioning of the 'main' object.
I'll need to double check what happens when saving an unversioned object - does it trigger a recursive publish?

@ivoba ivoba mentioned this pull request Feb 25, 2019
Closed
@robbieaverill
Copy link
Contributor

@NightJar fancy following up on this?

@NightJar NightJar self-assigned this Mar 1, 2019
@robbieaverill
Copy link
Contributor

I'm happy to merge this. @NightJar feel free to open follow up issues if you find anything you don't like as a result - thanks @kinglozzer!

@robbieaverill robbieaverill force-pushed the many-many-through-the-fire-and-flames branch from 41d59a2 to 600a39e Compare April 4, 2019 20:38
@robbieaverill
Copy link
Contributor

Also, nice branch name

@robbieaverill robbieaverill merged commit 6a26d76 into symbiote:3.2 Apr 4, 2019
@kinglozzer kinglozzer deleted the many-many-through-the-fire-and-flames branch April 4, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightJar NightJar NightJar left review comments

Assignees
No one assigned
Labels
affects/v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinglozzer @robbieaverill @NightJar