Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Symfony 7 #214

Closed
wants to merge 4 commits into from
Closed

Support Symfony 7 #214

wants to merge 4 commits into from

Conversation

trsteel88
Copy link
Contributor

Q A
Branch? "master" for new features / the branch of the current release for fixes
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets N/A
License MIT
Doc PR N/A

@trsteel88 trsteel88 mentioned this pull request Nov 30, 2023
Closed
@dbu
Copy link
Member

dbu commented Dec 1, 2023

thank you for getting this started.

phpcr-bundle is ongoing in doctrine/DoctrinePHPCRBundle#387 (and depends on more things...)

@trsteel88
Copy link
Contributor Author

Hey @dbu, it looks like doctrine/DoctrinePHPCRBundle#387 was merged. Do you think this one could be finalised soon?

dbu
dbu reviewed Feb 5, 2024
View reviewed changes
composer.json Show resolved Hide resolved
dbu
dbu reviewed Feb 5, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
dbu
dbu reviewed Feb 5, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
dbu
dbu reviewed Feb 5, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@dbu
Copy link
Member

dbu commented Feb 5, 2024

now we install with symfony 7 and see the issues.

@trsteel88 would you be motivated to look into the failing builds and try to solve the issues? i think its symfony 6 -> 7 BC breaks and in the symfony 6 build some incorrect mocking of the concrete class instead of the interface.

@dbu
Copy link
Member

dbu commented Apr 5, 2024

thanks for the help. i wrapped up and merged in #215

@dbu dbu closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trsteel88 @dbu