-
-
Notifications
You must be signed in to change notification settings - Fork 52
[Platform] Add support for Google vertex AI #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Platform] Add support for Google vertex AI #297
Conversation
14ae923
to
35d9a8b
Compare
35d9a8b
to
9124195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ship it
9124195
to
cd83b3b
Compare
Docs and AI bundle integration need to be added first. |
1346440
to
b08d7e7
Compare
* } | ||
* } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indention looks wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the PHP doc, the IDE doesn't apparently help with the indentation in this case.
I tried to correct the indentation now.
Thanks @junaidbinfarooq for your work on this - I think we're getting somewhere. In general it great to have that bridge, I still wonder tho about the amount of duplicated code with the Gemini bridge and we would need to support API Keys as well ... but both topics are fine as follow up |
@chr-hertel |
b08d7e7
to
605bf5e
Compare
605bf5e
to
f986f83
Compare
@junaidbinfarooq are all examples that you added working for you? |
@chr-hertel |
- Adds initial support to integrate text generation using vertex AI
- Adds support for embeddings
- Adds tests to verify the behavior
- Adds examples to interact with vertex ai
- Adds ai bundle integration
- Adds documentation for vertex ai
- Adds support to calculate the token usage
8a402e2
to
153ee1e
Compare
- Adds AI bundle integration
153ee1e
to
ce696af
Compare
Hmm, super weird 🤔 And where is that |
Changes proposed: