Create link_source_file helper to replace internal WebProfiler helper
#1456
Conversation
src/Twig/SourceCodeExtension.php
Outdated
| { | ||
| $text = str_replace('\\', '/', $file); | ||
| if (str_starts_with($text, $this->projectDir)) { | ||
| $text = mb_substr($text, \mb_strlen($this->projectDir)); |
There was a problem hiding this comment.
No need to use mbstring here to remove the string from the start (we know it already starts with it): substr($text, \strlen($this->projectDir)) works just fine (and would work even if the filesystem path is not in UTF-8)
There was a problem hiding this comment.
I agree, that was updated by php-cs-fixer.
| @@ -30,15 +30,15 @@ | |||
| <div class="tab-content" id="myTabContent"> | |||
| <div class="tab-pane show active" id="controller-code" role="tabpanel" aria-labelledby="controller-tab"> | |||
| {% if controller %} | |||
| <p class="file-link">{{ controller.file_path|format_file(controller.starting_line) }}</p> | |||
| <p class="file-link">{{ link_source_file(controller.file_path, controller.starting_line) }}</p> | |||
There was a problem hiding this comment.
why making it a Twig function and not a filter ?
There was a problem hiding this comment.
Because both arguments are equally required. It seems more coherent to me to have them at the same level.
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| namespace App\Twig; | |||
|
|
|||
| use Symfony\Component\DependencyInjection\Attribute\Autowire; | |||
| use Symfony\Component\ErrorHandler\ErrorRenderer\FileLinkFormatter; | |||
There was a problem hiding this comment.
This FileLinkFormatter class was moved in Symfony 6.4, I'll wait for the demo project to be upgraded.
There was a problem hiding this comment.
No worries. Let's merge this and then we'll update the other PR that upgrades the app to 6.4. Thanks.
|
Jérôme, thanks for taking care of this in preparation for the upstream changes in Symfony. |
Fix #1455