[CI] Adjust composer cache key hash to account for composer.lock removal #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jan 3, 2025
This PR was merged into the main branch. Discussion ---------- Remove the composer cache from the CI workflows I think there is little benefit anymore for this repository to have a composer cache in the CI workflows. With composer v2 the dependencies are downloaded in parallel which is a lot faster than composer v1. This makes the performance gains from the cache small since it also takes time to setup and save or restore the cache. Also the chance for a cache hit is low: - This repository has low traffic and the cache expires after a week which reduces the chance for a cache hit. - Every branch / PR get it's own cache which again reduces the chance for a cache hit. So I purpose to remove the composer cache to simplify the workflows. Replaces: #1538 Commits ------- a4baa11 Remove the composer cache from the CI workflows
|
Let's close this in favor of #1551, which removes the GitHub cache entirely because it's not that useful to us. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.