Add more entropy to the generated secret #1035
Open
+25
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosier
force-pushed
the
gen-secret
branch
2 times, most recently
from
33ce77d to
d96ab07
Compare
There was a problem hiding this comment.
👎 on my side:
- this changes the definition of the $length argument, which was about entropy size and now becomes result's size
- base58 is not worth the extra logic
return base64_encode(random_bytes($length)) would be just fine if the purpose is having a shorter result. (we could increase the default to 18 bytes to free the base64 string from any trainling =.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the "randomness" of the generated secret by extending the used characters from hexadecimal to base58.
I opted for base58 to keep the secret readable.