Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] revert #1598 #1607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[ci] revert #1598
symfony/recipes#1339 is now merged - we dont need to skip these tests anymore.
  • Loading branch information
jrushlow committed Sep 28, 2024
commit 33ee4a96f86546457b4a21ca3e84c39f7b6bd615
4 changes: 0 additions & 4 deletions tests/Maker/MakeEntityTest.php
Original file line number Diff line number Diff line change
@@ -120,8 +120,6 @@ public function getTestDetails(): \Generator
];

yield 'it_creates_a_new_class_and_api_resource' => [$this->createMakeEntityTest()
// @legacy - re-enable test when https://github.com/symfony/recipes/pull/1339 is merged
->skipTest('Waiting for https://github.com/symfony/recipes/pull/1339')
->addExtraDependencies('api')
->run(function (MakerTestRunner $runner) {
$runner->runMaker([
@@ -681,8 +679,6 @@ public function getTestDetails(): \Generator
];

yield 'it_makes_new_entity_no_to_all_extras' => [$this->createMakeEntityTestForMercure()
// @legacy - re-enable test when https://github.com/symfony/recipes/pull/1339 is merged
->skipTest('Waiting for https://github.com/symfony/recipes/pull/1339')
->addExtraDependencies('api')
// special setup done in createMakeEntityTestForMercure()
->run(function (MakerTestRunner $runner) {
Loading