Allow make:entity specify the table name
#1635
Open
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrYamous
changed the title
make:entity specify the table name
|
Struggling with tools in local but i'm going to have a look and those errors |
smnandre
reviewed
Jan 1, 2025
| @@ -40,15 +40,17 @@ public function __construct( | |||
| ) { | |||
| } | |||
|
|
|||
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT): string | |||
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT, ?string $tableName): string | |||
There was a problem hiding this comment.
Suggested change
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT, ?string $tableName): string | |
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT, ?string $tableName = null): string |
Menelion
approved these changes
Jan 9, 2025
src/Maker/MakeEntity.php
Outdated
| @@ -97,6 +97,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf | |||
| ->addOption('broadcast', 'b', InputOption::VALUE_NONE, 'Add the ability to broadcast entity updates using Symfony UX Turbo?') | |||
| ->addOption('regenerate', null, InputOption::VALUE_NONE, 'Instead of adding new fields, simply generate the methods (e.g. getter/setter) for existing fields') | |||
| ->addOption('overwrite', null, InputOption::VALUE_NONE, 'Overwrite any existing getter/setter methods') | |||
| ->addOption('table-name', null, InputOption::VALUE_NONE, 'Overwrite default table name') | |||
There was a problem hiding this comment.
Suggested change
| ->addOption('table-name', null, InputOption::VALUE_NONE, 'Overwrite default table name') | |
| ->addOption('table-name', 't', InputOption::VALUE_NONE, 'Overwrite default table name') |
| { | ||
| $repoClassDetails = $this->generator->createClassNameDetails( | ||
| $entityClassDetails->getRelativeName(), | ||
| 'Repository\\', | ||
| 'Repository' | ||
| ); | ||
|
|
||
| $tableName = $this->doctrineHelper->getPotentialTableName($entityClassDetails->getFullName()); | ||
| if (null === $tableName) { |
There was a problem hiding this comment.
Wouldn't you consider handling the most common case of pluralizing the class name somehow? Maybe via another option or something else? You can use this Symfony inflector capability.
There was a problem hiding this comment.
This is a good point. But I think it's outside the scope of this PR, my purpose is to be able to explicitly choose the table name, not to change the default behavior. Both can also coexist, I think.
There was a problem hiding this comment.
I keep the idea to open a new PR in the next few days, or maybe you want to do it
smnandre
reviewed
Jan 17, 2025
| @@ -40,15 +40,17 @@ public function __construct( | |||
| ) { | |||
| } | |||
|
|
|||
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT): string | |||
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT, string $tableName = null): string | |||
There was a problem hiding this comment.
Suggested change
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT, string $tableName = null): string | |
| public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $apiResource, bool $withPasswordUpgrade = false, bool $generateRepositoryClass = true, bool $broadcast = false, EntityIdTypeEnum $useUuidIdentifier = EntityIdTypeEnum::INT, ?string $tableName = null): string |
Missed the ? here :)
smnandre
reviewed
Jan 17, 2025
src/Maker/MakeEntity.php
Outdated
| @@ -97,6 +97,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf | |||
| ->addOption('broadcast', 'b', InputOption::VALUE_NONE, 'Add the ability to broadcast entity updates using Symfony UX Turbo?') | |||
| ->addOption('regenerate', null, InputOption::VALUE_NONE, 'Instead of adding new fields, simply generate the methods (e.g. getter/setter) for existing fields') | |||
| ->addOption('overwrite', null, InputOption::VALUE_NONE, 'Overwrite any existing getter/setter methods') | |||
| ->addOption('table-name', 't', InputOption::VALUE_NONE, 'Overwrite default table name') | |||
There was a problem hiding this comment.
Overwrite seems more something to change existing things no ?
I'd say this will be also (mainly?) used during first Entitiy creation ?
Maybe something more like "Set custom table name" ?
Feel free to ignore if you disagree, just a comment passing by ;)
There was a problem hiding this comment.
To be honest I hadn't thought that far ahead. But I agree with you for this change, sounds better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a try on #1626