Replace php-cs-fixer/shim with friendsofphp/php-cs-fixer #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency php-cs-fixer/shim was replaced with friendsofphp/php-cs-fixer so that the decision over which package to use is on the user.
|
|
Then maybe the change should be reverted and/or php-cs-fixer should be added as an optional dependency? If php-cs-fixer is installed globally neither |
This was referenced Jan 14, 2025
kbond
added a commit
that referenced
this pull request
Jan 15, 2025
…al PHAR) (kbond) This PR was merged into the 1.x-dev branch. Discussion ---------- Revert #1575 (Use a PHP-CS-Fixer shim rather than an external PHAR) This reverts #1575. This PR has caused a lot of trouble as it made php-cs-fixer a required dep which installs a recipe. See #1644, #1653, #1651, #1648. We can't have php-cs-fixer (or the shim) as a required dependency. I think we need to have this bundle only use php-cs-fixer if available/configured (or drop it entirely). I'm not sure why it is used at all - feels like a lot of added complexity... Commits ------- 41744d7 Revert "feature #1575 [make:*] Use a PHP-CS-Fixer shim rather than an external PHAR"
|
I've reverted #1575 and released v1.62.1. It was causing a lot of problems. I think we need to rethink the php-cs-fixer integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1575 the dependency
php-cs-fixer/shimwas added to replace a self packaged phar of php-cs-fixer.This change causes
php-cs-fixer/shimto be installed in all projects usingsymfony/maker-bundle, even if the non-shim package was used before. In symfony flex projects this also causes further unexpected changes sincephp-cs-fixer/shimalso executes an additional recipe modifying additional files. (#1644 #1648)I have changed the dependency to
friendsofphp/php-cs-fixerinstead, so the decision on which package to use can be made by the user instead of forcing the use of the shim package. The execution in\Symfony\Bundle\MakerBundle\Util\TemplateLinterremains the same for both packages.