[Intl] Add PHP 8.5 IntlListFormatter as installable polyfill
#532
Conversation
Ayesh
force-pushed
the
feat/intllistformatter
branch
from
fa3be1e to
fa352fc
Compare
Adds a new polyfill component `symfony/polyfill-intl-listformatter` that provides the functionality of the new `IntlListFormatter` to PHP 7.2 and later. It is a new composer-installable package (similar to how Intl `MessageFormatter` is a separate installable package, and the PHP 8.5 polyfill can require it as a dependency too. It only supports `en` locale. However, PHP applications that require this package can extend the namespaced polyfill (`\Symfony\Polyfill\Intl\ListFormatter\IntlListFormatter`) and add their own list patterns by extending the static variable (`\Symfony\Polyfill\Intl\ListFormatter\IntlListFormatter::$listPatterns`) that holds these patterns. - [ICU listPatterns](https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-misc-full/main/en/listPatterns.json) - [php-src commit](php/php-src@3f7545245) - [PHP.Watch: IntlListFormatter](https://php.watch/versions/8.5/IntlListFormatter) Closes symfonyGH-530.
Ayesh
force-pushed
the
feat/intllistformatter
branch
from
fa352fc to
3b446ce
Compare
|
// cc @BogdanUngureanu, I could use your inputs/review here :) |
| * | ||
| * @internal | ||
| */ | ||
| class IntlListFormatter |
There was a problem hiding this comment.
It should be final, non-serializable and not able to clone it.
| ]); | ||
| } | ||
|
|
||
| protected function getListPattern(): array { |
| private $width; | ||
|
|
||
| protected static $listPatterns = [ | ||
| 'en' => [ |
There was a problem hiding this comment.
Maybe make it clear that this is en_US since it's using the Oxford comma?
| ) { | ||
| $exceptionClass = PHP_VERSION_ID >= 80000 ? \ValueError::class : \InvalidArgumentException::class; | ||
| if ($locale !== 'en' && strpos($locale, 'en') !== 0) { | ||
| throw new $exceptionClass('Invalid locale, only "en" and "en-*" locales are supported'); |
There was a problem hiding this comment.
I have some mixed feelings about this. Since it's using the en-US set, for en-gb it would return a different result than the real class.
|
This should be added in symfony/polyfill-intl-icu (with the other formatters) instead of being a new package IMO
Extending the internal class is not covered by BC and is not a supported use case. |
Adds a new polyfill component
symfony/polyfill-intl-listformatterthat provides the functionality of the newIntlListFormatterto PHP 7.2 and later.It is a new composer-installable package (similar to how Intl
MessageFormatteris a separate installable package, and the PHP 8.5 polyfill can require it as a dependency too.It only supports
enlocale. However, PHP applications that require this package can extend the namespaced polyfill(
\Symfony\Polyfill\Intl\ListFormatter\IntlListFormatter) and add their own list patterns by extending the static variable (\Symfony\Polyfill\Intl\ListFormatter\IntlListFormatter::$listPatterns) that holds these patterns.Closes GH-530.