Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added StfalconTinymceBundle #26

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented May 14, 2017

Q A
License MIT

About the bundle:


@stfalcon you are the creator of this bundle, so it'd be great if you could review this. The idea of the recipes is to provide no configuration or a minimal configuration. The default config options of the bundle should be the good ones for most of the users. So, I propose to include in the recipe config only the two options that you may need to change or at least control more closely.

Do you agree? Would you add more must-have config options? Would you remove these? Thanks!

@javiereguiluz javiereguiluz changed the title Added StfalconTinymceBundle (WIP) Added StfalconTinymceBundle May 14, 2017
@javiereguiluz javiereguiluz changed the title (WIP) Added StfalconTinymceBundle Added StfalconTinymceBundle May 26, 2017
@stfalcon
Copy link

@javiereguiluz yes, of course. thanks dude! ;)

Copy link
Contributor

@symfony-bot symfony-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@fabpot
Copy link
Member

fabpot commented Nov 3, 2017

@symfony-flex-server review please

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

"Stfalcon\\Bundle\\TinymceBundle\\StfalconTinymceBundle": ["all"]
},
"copy-from-recipe": {
"etc/": "%ETC_DIR%/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be updated.

"config/": "%CONFIG_DIR%/"

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@Nyholm
Copy link
Member

Nyholm commented Dec 31, 2017

Thank you @javiereguiluz. I asked the bundle to tag 2.2. Could you move the recipe from 2.1 to 2.2? After that I think you are done.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@fre5h
Copy link
Contributor

fre5h commented Jan 16, 2018

Tag v2.2.0 for this bundle is ready. You can use it.

@Nyholm
Copy link
Member

Nyholm commented Jan 16, 2018

@symfony-flex-server review please

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@Nyholm
Copy link
Member

Nyholm commented Jan 17, 2018

@symfony-flex-server review please

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@javiereguiluz
Copy link
Member Author

@Nyholm this PR stalled. What should we do here? Update something? Close it? Thanks!

@Nyholm
Copy link
Member

Nyholm commented Jul 26, 2018

We are blocked by stfalcon/TinymceBundle#225. And the maintainers do not seam to be eager to reply to me...

@stfalcon or @metalslave, could you spend 3 minutes on stfalcon/TinymceBundle#232 ?

@javiereguiluz
Copy link
Member Author

I'm closing this because the upstream bundle is no longer active or it's not interested in this. Thank you and sorry for having wasted your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants