Fix Symfony 7 compatibility #121
Conversation
jordisala1991
force-pushed
the
feature/sf7
branch
2 times, most recently
from
d26b452 to
b7646a9
Compare
jordisala1991
force-pushed
the
feature/sf7
branch
from
b7646a9 to
29379e6
Compare
|
friendly ping @nicolas-grekas @OskarStark |
|
Can you take a look at this one? currently is blocking update for some bundles using security-acl and the fix is not complex :) Thank you |
Co-authored-by: Nicolas Grekas <[email protected]>
|
Any news about a release with this PR? This is blocking my update to SF7. |
Really! I'm also in the same situation, help us. |
| */ | ||
| trait AclVoterTrait | ||
| { | ||
| public function vote(TokenInterface $token, mixed $subject, array $attributes): int |
There was a problem hiding this comment.
the way to support multiple versions without such trait is actually to add the return type without adding the parameter type, thanks to variance rules.
however, note that adding the return type requires releasing this as a major version of the package, as this class is not final or internal.
There was a problem hiding this comment.
IMO, since this major version was previously tagged as it supports sf 7, we should fix it here, and in the next major remove all the unnecessary code and leave the voter clean again. wdyt? I see it more like bug fixing rather than adding new things.
|
Thank you @jordisala1991. |
|
New release done as well. |
Thank you. |
8 participants
Continuation of #116
I want to see what is failing to fix it.
Might close: #112 #115 #114 #121