Fixes MySQL distinction of 3 or 4byte UTF encoding. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL error: 1071 Specified key was too long; max key length is 767 bytes
This comment has been minimized.
This comment has been minimized.
|
This PR is not relevant for MySQL 5.7/8.0 anymore, is it? |
stof
reviewed
Jul 21, 2021
| @@ -33,6 +42,17 @@ public function __construct(array $options, Connection $connection = null) | |||
| { | |||
| $schemaConfig = null === $connection ? null : $connection->getSchemaManager()->createSchemaConfig(); | |||
|
|
|||
| $params = $connection->getParams(); | |||
| if(array_key_exists('charset2', $params)) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL error: 1071 Specified key was too long; max key length is 767 bytes
The FIX had already been given as previous pull-request, but to my taste:
I did't want to use it, that's why I purpose an other possible FIX for the utf8 vs. utf8mb configs.
It solves issue #7