Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Create Framework / Unit Testing page #19183

Merged

Conversation

faissaloux
Copy link
Contributor

@faissaloux faissaloux commented Nov 25, 2023

Hello 👋🏻

In this PR I have updated the deprecated will($this->returnValue()) to willReturn(), and the phpunit config file.

@carsonbot carsonbot added this to the 5.4 milestone Nov 25, 2023
@OskarStark
Copy link
Contributor

symfony/phpunit-bridge does not support PHPUnit 10 now, so the docs should reflect the config for PHPUnit 9.6, which is the current PHPUnit version.

@faissaloux
Copy link
Contributor Author

symfony/phpunit-bridge does not support PHPUnit 10 now, so the docs should reflect the config for PHPUnit 9.6, which is the current PHPUnit version.

So we need to specify the version on the phpunit installation command, because it's installing the current version which is 10 and it conflicts with the rest of the doc.

@OskarStark If accepted I'll update the installation command specifying the version 9.6 instead of updating the doc to phpunit10.

@OskarStark
Copy link
Contributor

Sorry I missed this PR :-(

@faissaloux
Copy link
Contributor Author

@OskarStark

Will symfony/phpunit-bridge not support phpunit10 anytime soon?

Should I update the installation command specifying the version 9.6?

@OskarStark
Copy link
Contributor

Please update it, as I don't know when it will be supported

@faissaloux
Copy link
Contributor Author

@OskarStark Done!

@javiereguiluz
Copy link
Member

Thanks Faissal, sorry it took us so long to merge this ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz force-pushed the update-unittesting-createframework-page branch from 3af3d14 to 97bfcfc Compare July 24, 2024 08:57
@javiereguiluz javiereguiluz merged commit 6f1a190 into symfony:5.4 Jul 24, 2024
1 check passed
@faissaloux faissaloux deleted the update-unittesting-createframework-page branch July 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants