Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger][Beanstalkd] Add Priority support #20696

Merged

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Feb 26, 2025

Adds explanation about the new BeanstalkdPriorityStamp introduced by symfony/symfony#59273.
Fixes #20513.

Ping @HypeMC for the review.
Regards.

Adds explanation about the new `BeanstalkdPriorityStamp` introduced by symfony/symfony#59273
Fixes symfony#20513
new BeanstalkdPriorityStamp(0), // Highest priority
]);

As defined by the Beanstalkd protocol, the priority value must be an integer between 0 (highest priority) and 2**32 (lowest priority).
Copy link
Contributor

@HypeMC HypeMC Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, according to the specification:

  • is an integer < 2**32.

So the lowest number is 2**32 - 1.

@OskarStark OskarStark changed the title [Messenger] Priority support for Beanstalkd bridge [Messenger][Beanstalkd] Add Priority support Feb 27, 2025
Comment on lines +1796 to +1798
when dispatching a message:

.. code-block:: php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when dispatching a message:
.. code-block:: php
when dispatching a message::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed while merging.


.. versionadded:: 7.3

``BeanstalkdPriorityStamp`` support was added in Symfony 7.3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``BeanstalkdPriorityStamp`` support was added in Symfony 7.3.
``BeanstalkdPriorityStamp`` support was introduced in Symfony 7.3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done while merging.

@javiereguiluz javiereguiluz merged commit 0a49a8e into symfony:7.3 Feb 27, 2025
2 of 3 checks passed
@javiereguiluz
Copy link
Member

Florent, thanks a lot for this contribution 🙏

Please, note that while merging we reword the original content (see 04f5498). Don't think that your original contribution was wrong. Please, understand that we do this to make contributions match the existing docs style. Also, for super long pages (like messenger.rst, with almost 4,000 lines) it's very important to be as concise as possible (While maintaining the original meaning) so that's why we do these kind of changes while merging. Thanks!

@Spomky Spomky deleted the features/59273-BeanstalkdPriorityStamp branch February 27, 2025 16:04
@Spomky
Copy link
Contributor Author

Spomky commented Feb 27, 2025

Many thanks @javiereguiluz, @OskarStark and @HypeMC 👌.
I'll pay attention to the docs style in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger] Add BeanstalkdPriorityStamp to Beanstalkd bridge
5 participants