-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Messenger][Beanstalkd] Add Priority support #20696
[Messenger][Beanstalkd] Add Priority support #20696
Conversation
Adds explanation about the new `BeanstalkdPriorityStamp` introduced by symfony/symfony#59273 Fixes symfony#20513
new BeanstalkdPriorityStamp(0), // Highest priority | ||
]); | ||
|
||
As defined by the Beanstalkd protocol, the priority value must be an integer between 0 (highest priority) and 2**32 (lowest priority). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, according to the specification:
- is an integer < 2**32.
So the lowest number is 2**32 - 1
.
when dispatching a message: | ||
|
||
.. code-block:: php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when dispatching a message: | |
.. code-block:: php | |
when dispatching a message:: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed while merging.
|
||
.. versionadded:: 7.3 | ||
|
||
``BeanstalkdPriorityStamp`` support was added in Symfony 7.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``BeanstalkdPriorityStamp`` support was added in Symfony 7.3. | |
``BeanstalkdPriorityStamp`` support was introduced in Symfony 7.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done while merging.
Florent, thanks a lot for this contribution 🙏 Please, note that while merging we reword the original content (see 04f5498). Don't think that your original contribution was wrong. Please, understand that we do this to make contributions match the existing docs style. Also, for super long pages (like |
Many thanks @javiereguiluz, @OskarStark and @HypeMC 👌. |
Adds explanation about the new
BeanstalkdPriorityStamp
introduced by symfony/symfony#59273.Fixes #20513.
Ping @HypeMC for the review.
Regards.