[Autocomplete] Support the render.loading_more Tom Select option
#1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ed
reviewed
Dec 14, 2023
vgaret
force-pushed
the
autocomplete/loading-more-text
branch
from
e9959f5 to
01ec1de
Compare
weaverryan
force-pushed
the
autocomplete/loading-more-text
branch
from
01ec1de to
c1ce573
Compare
|
This is a very high-quality PR. Thank you @vgaret and congrats on this very polished effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my proposal for the support of the
render.loading_moreoption from the Virtual Scroll plugin of Tom Select (docs). I also suggested a French translation, as it is my main language.NB: I have slightly modified the default value ("Loading more results ... " ➡️ "Loading more results...").