bug #121 [stimulus-controller] fix bool attributes from being rendere…

…d incorrectly (jrushlow) This PR was squashed before being merged into the main branch. Discussion ---------- [stimulus-controller] fix bool attributes from being rendered incorrectly fixes #118 Commits ------- 2694dca [stimulus-controller] fix bool attributes from being rendered incorrectly
symfony · Apr 26, 2021 · f282fb1 · f282fb1
2 parents 0cd625e + 2694dca
commit f282fb1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/Twig/StimulusTwigExtension.php b/src/Twig/StimulusTwigExtension.php
@@ -59,6 +59,10 @@ public function renderStimulusController(Environment $env, $dataOrControllerName
                     $value = json_encode($value);
                 }
 
+                if (is_bool($value)) {
+                    $value = $value ? 'true' : 'false';
+                }
+
                 $key = twig_escape_filter($env, $this->normalizeKeyName($key), 'html_attr');
                 $value = twig_escape_filter($env, $value, 'html_attr');
 

diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php
@@ -214,7 +214,7 @@ public function provideRenderStimulusController()
                 ],
             ],
             'controllerValues' => [],
-            'expected' => 'data-controller="my-controller" data-my-controller-boolean-value="1" data-my-controller-number-value="4" data-my-controller-string-value="str"',
+            'expected' => 'data-controller="my-controller" data-my-controller-boolean-value="true" data-my-controller-number-value="4" data-my-controller-string-value="str"',
         ];
 
         yield 'single-controller-nested-data' => [
@@ -247,7 +247,7 @@ public function provideRenderStimulusController()
                 ],
             ],
             'controllerValues' => [],
-            'expected' => 'data-controller="symfony--ux-dropzone--dropzone" data-symfony--ux-dropzone--dropzone-my-key-value="1"',
+            'expected' => 'data-controller="symfony--ux-dropzone--dropzone" data-symfony--ux-dropzone--dropzone-my-key-value="true"',
         ];
 
         yield 'short-single-controller-no-data' => [
@@ -261,6 +261,18 @@ public function provideRenderStimulusController()
             'controllerValues' => ['myValue' => 'scalar-value'],
             'expected' => 'data-controller="my-controller" data-my-controller-my-value-value="scalar-value"',
         ];
+
+        yield 'false-attribute-value-renders-false' => [
+            'dataOrControllerName' => 'false-controller',
+            'controllerValues' => ['isEnabled' => false],
+            'expected' => 'data-controller="false-controller" data-false-controller-is-enabled-value="false"',
+        ];
+
+        yield 'true-attribute-value-renders-true' => [
+            'dataOrControllerName' => 'true-controller',
+            'controllerValues' => ['isEnabled' => true],
+            'expected' => 'data-controller="true-controller" data-true-controller-is-enabled-value="true"',
+        ];
     }
 
     /**