Reset assets on FINISH_REQUEST.

[Warxcell]

Fixes #90, #94

[weaverryan]

Sorry for the slow merge - thank you @Warxcell!

[blankse]

@weaverryan After upgrading to v1.14.0 I have following error:
I have 2 entrypoints in my webpage. One on the top and one on the bottom. In v1.13.2 the runtime.js from webpack is only loaded in the entrypoint on the top. Now it is also loaded at the bottom and scripts are executed twice which makes makes mistackes (double click events...)

What can I do to have the runtime.js only on top?

[Warxcell]

Hm, do you have sub-requests in-between? Can you provide reproducible code in some repo so I can fork and add a fix? Or directly add test case ?

[blankse]

@Warxcell Yes there are sub-requests in-between. I can try to give you an reproducible code example.

[noahduncan]

We're seeing similar issues with duplicate runtime.js script tags for our code. I see use cases both ways, sometimes you want your all script tags on every request, sometimes you don't. To me, that makes it feel like the option should be configurable somewhere.

[scrummer]

@Warxcell @weaverryan We also ran into the problem, that one of our projects kept loading the runtime.js multiple times. In our case it lead to forms being sent multiple times (including submission emails). Really had to look deep to figure out why it did that.
However; I kind of get the point why you guys implemented that feature. For us, this problem occured in the Pimcore ecosystem which uses (depending on the use-case) some up to a lot sub-requests.

As already stated; from a developers perspective I totally understand why you implemented that, but I think this sub-request thingy could break a lot of stuff. We were happy that it was "just" a contact form. I was wondering what would've happened if we updated the bundle in one of our larger shop systems (multiple orders? multiple items in the cart by accident? etc etc).

Unfortunately I can't really think of a "better" alternative than the Request-Finished event. But I think it really makes sense to think about it, how it could impact users.

Thank you, stay healthy!

BR,
Jan

[H4wKs]

@Warxcell as @zing-james explained in #166, if you use the twig render function you end up with runtime.js being load twice, this is a huge side effect as I believe many people (including myself) use this in their projects.

[kuldippujara]

Hi @Warxcell, @weaverryan,

I am having the same issue with embed controller after the update. I have check the other use cases where users want to reset the assets. I want to provide a suggestion that if we can differentiate the sub requests then we can put the condition when we want to reset and when we don't want to.

1 option is to add attribute in request similar to _format eg. _renderer : inline / fragment
which will be only available if its render by Fragment renderer.
then we can fix both the scenarios.

waiting for feedback.

Happy to create PR for Symfony and add attribute and then create PR to fix the issue.

[Warxcell]

1 option is to add attribute in request similar to _format eg. _renderer : inline / fragment which will be only available if its render by Fragment renderer. then we can fix both the scenarios.

Sounds ok to me.