Allow entrypoints.json to be hosted remotely #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
allow-entrypoints-file-to-be-hosted-remotely
branch
2 times, most recently
from
9700a5e to
664a4f1
Compare
Kocal
force-pushed
the
allow-entrypoints-file-to-be-hosted-remotely
branch
from
664a4f1 to
f5b9a1d
Compare
|
Thank you @rlvdx. |
Kocal
added a commit
to Kocal/webpack-encore-bundle
that referenced
this pull request
Oct 1, 2024
Kocal
added a commit
that referenced
this pull request
Oct 1, 2024
…r (dkarlovi, Kocal) This PR was merged into the 2.x branch. Discussion ---------- fix: correctly wire the build-time file into kernel.build_dir See symfony/symfony#50357 /cc `@Okhoshi` Commits ------- 9f2e8b5 fix(config): remove useless service from #236 e9ef4b5 fix: correctly wire the build-time file into kernel.build_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
See #97, this PR uses the Symfony HttpClient to remotely fetch the entrypoints file, but also to allow mocking in a proper way.
It also add/adapt many tests, and improve the documentation.