Fix missing integrity hash on preload tags #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hugo Alliaume <[email protected]>
Kocal
changed the title
Kocal
force-pushed
the
fix/integrity-hash-preload
branch
from
f5b5c97 to
d682c35
Compare
Signed-off-by: Hugo Alliaume <[email protected]>
Kocal
force-pushed
the
fix/integrity-hash-preload
branch
from
d682c35 to
b8219a8
Compare
Kocal
added a commit
to symfony/webpack-encore
that referenced
this pull request
Oct 2, 2024
…names with a query-string (Kocal) This PR was merged into the main branch. Discussion ---------- Fix issue between `Encore.enableIntegrityHashes()` and filenames with a query-string | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update CHANGELOG.md file --> | Deprecations? | no <!-- please update CHANGELOG.md file --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility. --> When working on symfony/webpack-encore-bundle#237, I haven't able to see integrity hashes added on `<link>` tags, because my project uses query-string in generated filenames, but the bundle was not able to get those integrity hashes (because the `entrypoints.json` file contained `"/build/sentry.js": "sha384-hash"` instead of `"/build/sentry.js?v=b86ff72e": "sha384-hash"`) Commits ------- c965684 Fix integrity hashes with query string, use the original assets name in "integrity" map
|
Thank you @arnaud-ritti. |
|
Hurray! 🎉 |
|
Even with this latest version, I`m not getting any hashes added, anywhere. Of course .enableIntegrityHashes(Encore.isProduction()) is defined. Can you share your HTML definition? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to edit #161, so I've opened a new PR and made changes here.
Fix #101, fix #225
On an existing app, integrity hashes and other attributes are nicely injected into
Linkheader: