Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .travis.yml #8

Closed
wants to merge 2 commits into from
Closed

Update .travis.yml #8

wants to merge 2 commits into from

Conversation

andreybolonin
Copy link

No description provided.

@weaverryan
Copy link
Member

Hey @andreybolonin!

Thanks for this. It looks like we need to dump our php-cs-fixer dependency to some higher version that allows php 7.3. Could you check into that?

Thanks!

@andreybolonin
Copy link
Author

@weaverryan still waiting PHP-CS-Fixer/PHP-CS-Fixer#3697

@keradus keradus mentioned this pull request Jan 6, 2019
Merged
@weaverryan
Copy link
Member

Thanks for getting this started! Closing in favor of #25 now

@weaverryan weaverryan closed this Jan 17, 2019
weaverryan added a commit that referenced this pull request Jan 17, 2019
@weaverryan
minor #25 DX: Add PHP 7.3 to Travis and upgrade PHP CS Fixer (keradus)
74b4e65 
This PR was squashed before being merged into the master branch (closes #25).

Discussion
----------

DX: Add PHP 7.3 to Travis and upgrade PHP CS Fixer

Replaces #8

Commits
-------

5a93879 DX: Travis - add job running on PHP 7.3
08042a5 DX: Upgrade PHP CS Fixer to one that supports PHP 7.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreybolonin @weaverryan