Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set supplementary groups for target user #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set supplementary groups for target user #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 46 additions & 7 deletions lib/Daemon/Control.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ my @accessors = qw(
uid path gid scan_name stdout_file stderr_file pid_file fork data
lsb_start lsb_stop lsb_sdesc lsb_desc redirect_before_fork init_config
kill_timeout umask resource_dir help init_code
prereq_no_process foreground
prereq_no_process foreground use_supplementary_groups
);

my $cmd_opt = "[start|stop|restart|reload|status|show_warnings|get_init_file|help]";
Expand Down Expand Up @@ -68,12 +68,13 @@ sub new {

# Create the object with defaults.
my $self = bless {
color_map => { red => 31, green => 32 },
redirect_before_fork => 1,
kill_timeout => 1,
quiet => 0,
umask => 0,
foreground => 0,
color_map => { red => 31, green => 32 },
redirect_before_fork => 1,
kill_timeout => 1,
quiet => 0,
umask => 0,
foreground => 0,
use_supplementary_groups => 0,
}, $class;

for my $accessor ( @accessors ) {
Expand Down Expand Up @@ -120,6 +121,40 @@ sub _set_gid_from_name {

}

sub _get_groups_for_user {
my ( $self, $username ) = @_;
my @groups;

while ( my ( $name, $password, $gid, $users ) = getgrent ) {
if ( grep { $_ eq $username } split /\s/, $users ) {
push @groups, $gid;
}
}

return \@groups;
}

sub _set_supplementary_groups {
my ( $self, $uid, $gid ) = @_;

my $pw_name = getpwuid( $uid );
return unless defined $pw_name; # no entry => no groups

my $groups_aref = $self->_get_groups_for_user( $pw_name );

unless ( grep { $_ == $gid } @$groups_aref ) {
unshift @$groups_aref, $gid;
}

my $groups_str = join( ' ' => $gid, @$groups_aref );

local $!;
$) = $groups_str;
die "Error: Couldn't set groups $groups_str: $!" if $!;

$self->trace( '$EFFECTIVE_GROUP_ID = ' . $groups_str );
}

sub redirect_filehandles {
my ( $self ) = @_;

Expand Down Expand Up @@ -197,6 +232,10 @@ sub _double_fork {
}

if ( $self->uid ) {
if ( $self->use_supplementary_groups ) {
$self->_set_supplementary_groups( $self->uid, $self->gid );
}

setuid( $self->uid );

$ENV{USER} = $self->user || getpwuid($self->uid);
Expand Down