Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import using System ID #40

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

jonmifsud
Copy link

Should be a good start to fixing #19 supports both creating new entries and updating existing.

We might need an option to only update existing if I understand #19 properly. I've tested this on a number of imports and updates with different sections, I don't seem to have any problems so far.

It's important to note that using the Entry ID for imports/updates it will override any other setting that one sets for unique, and the entry id will be the only unique variable used for the import.

@jonmifsud jonmifsud mentioned this pull request Jan 15, 2015
@jonmifsud
Copy link
Author

@brendo / @nilshoerrmann This is also included within #42 - however can be tested and merged separately.

@nilshoerrmann
Copy link
Contributor

I just checked this and it seems to work fine – thanks a lot, Jonathan!

From a UI point of view, I'd also add an is unique toggle to the entry id field. The other toggles could just be deactivated using JavaScript, and a note Update entries based on their id could replace the checkbox label Can update existing entries at the bottom of the form. What do you think?

@jonmifsud
Copy link
Author

Thanks for checking it out. UI wise makes sense I think. The U.S. Unique
for entry id would be forced right? Not an optional
On Thu, 30 Jul 2015 at 10:44 Nils Hörrmann [email protected] wrote:

I just checked this and it seems to work fine – thanks a lot, Jonathan!

From a UI point of view, I'd also add an is unique toggle to the entry id
field. The other toggles could just be deactivated using JavaScript, and a
note Update entries based on their id could replace the checkbox label Can
update existing entries at the bottom of the form. What do you think?


Reply to this email directly or view it on GitHub
#40 (comment)
.

@nilshoerrmann
Copy link
Contributor

That's what I meant by saying "deactive the others using JavaScript".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants