aligning README.md and CONTRIBUTING.md to FINOS project blueprint language #12
Conversation
| clj-symphony | ||
| Copyright 2016 Fintech Open Source Foundation | ||
| clj-symphony - FINOS | ||
| Copyright 2016-2019 Symphony LLC |
There was a problem hiding this comment.
This copyright notice is incorrect. Copyright notices only include the year of first publication - they are inherently open ended from that year forward.
There was a problem hiding this comment.
Furthermore, this code was developed by FINOS staff (i.e. myself), so the original copyright attribution is correct. Symphony LLC has had no input to this project whatsoever.
| @@ -1,5 +1,4 @@ | |||
| # Contributing to clj-symphony | |||
| :+1: First off, thanks for taking the time to contribute! :+1: | |||
There was a problem hiding this comment.
Please re-introduce. Positively encouraging community members to contribute to the project, despite the additional effort imposed on them by the bureaucratic steps outlined here, is an important focus.
| 3. Read our [contribution guidelines](.github/CONTRIBUTING.md) and [Community Code of Conduct](https://www.finos.org/code-of-conduct) | ||
| 4. Commit your changes (`git commit -am 'Add some fooBar'`) | ||
| 5. Push to the branch (`git push origin feature/fooBar`) | ||
| 6. Create a new Pull Request |
There was a problem hiding this comment.
Please change to:
6. Create a new Pull Request against the `dev` branch - PRs submitted to other branches will be rejected
|
|
||
| Distributed under the [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0). | ||
| Copyright 2016-2019 Symphony LLC |
There was a problem hiding this comment.
As mentioned above, this copyright notice is incorrect in (at least) two ways:
- It only requires a year of first publication - copyrights are inherently open ended into the future
- The copyright holder of this code is FINOS, not Symphony LLC, and as the original author I am opposed to any reassignment of copyright away from FINOS (if that's what's being proposed)
| @@ -56,7 +59,7 @@ For now, deployment of release versions (i.e. from `master`, when a new version | |||
| * For documentation contributions, follow the general structure, language, and tone of the [existing docs](https://github.com/symphonyoss/clj-symphony/wiki). | |||
| * Keep commits small and cohesive - if you have multiple contributions, please submit them as independent commits (and ideally as independent PRs too). | |||
| * Reference issue #s if your PR has anything to do with an issue (even if it doesn't address it). | |||
| * Minimise non-functional changes (e.g. whitespace shenanigans). | |||
| * Minimise non-functional changes (e.g. whitespace). | |||
aligning README.md and CONTRIBUTING.md to FINOS project blueprint language