Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(+semver: feature) Add raw topic message type #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annymsMthd
Copy link
Contributor

Signed-off-by: Joshua Benjamin [email protected]

@annymsMthd
Copy link
Contributor Author

Wanted to get this out there to get eyes on it early. I had this change local for a bit and had to do some merge craziness so I wanted to make sure the previous commit in master is gtg.

@annymsMthd annymsMthd marked this pull request as draft January 21, 2022 23:21
@cuevaskoch
Copy link
Contributor

cuevaskoch commented Jan 22, 2022

I'm a big fan of the snapshots for testing! Also this implementation for a raw topic type looks good to me in general, but I plan to review more carefully later. May I ask what your use case is? Message schemas are a pretty core part of the kafmesh conceptual framework IMO.

@annymsMthd
Copy link
Contributor Author

annymsMthd commented Jan 22, 2022

Sure I can expand on that. We have open telemetry collectors running in all of of our clusters. We have those shipping the spans to kafka. We use the raw message type to process those spans and everything after that gets a schema. Basically ingesting data into the mesh that we don't have full control over.
#34

@annymsMthd
Copy link
Contributor Author

name: tracing
description: The tracing handles trace processing.

processors:
  - name: ingresser
    definition: reads records from the open telemetry topic
    inputs:
      - message: opentelemetry
        topic: traces
        type: raw
    outputs:
      - message: serviceName.resourceSpans

  - name: logger
    definition: logs traceIds for searching
    inputs:
      - message: serviceName.resourceSpans
    outputs:
      - message: serviceName.spanLog

sinks:
  - name: tempo sink
    description: sinks spans into grafana tempo
    message: serviceName.resourceSpans

  - name: loki sink
    description: sinks spans logs into loki for queries
    message: serviceName.spanLog

Example of our configuration

@cuevaskoch
Copy link
Contributor

👍 lgtm, thanks!

@annymsMthd annymsMthd marked this pull request as ready for review January 26, 2022 17:52
@annymsMthd annymsMthd changed the title WIP: (+semver: feature) Add raw topic message type (+semver: feature) Add raw topic message type Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants