This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Use passport for authentication #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the surface everything looks cool, but I'm not going to have time to do an actual in depth review, and familiarise myself with passport until this weekend. I'm cool to approve this now, and I trust that it's fine, but if you want me to really check everything I might need a little longer. |
|
No worries, this is mostly just following the nestjs tutorial; just wanted to make sure I'm not doing anything stupid (like allowing the none algorithm?). |
thewrongjames
approved these changes
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make implementing SSO easier, I swear.