Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notification permission for api level >=33 (fixes #1976) #1983

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Add notification permission for api level >=33 (fixes #1976) #1983

merged 7 commits into from
Oct 11, 2023

Conversation

githubashutoshsoni
Copy link
Contributor

Added notification permission.

@githubashutoshsoni githubashutoshsoni mentioned this pull request Oct 9, 2023
Closed
@bt90
Copy link
Contributor

bt90 commented Oct 9, 2023

Thank you very much for working on this :)

I hope that I have enough time tonight to test the app changes.

@githubashutoshsoni
Copy link
Contributor Author

Sure, @bt90 Let me know if anything else needs to be changed.

@imsodin imsodin changed the title added notification permission for api level 33 and above. Add notification permission for api level 33 and above Oct 9, 2023
imsodin
imsodin approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@imsodin imsodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Waiting for @bt90's feedback before merging.

@githubashutoshsoni
Copy link
Contributor Author

githubashutoshsoni commented Oct 11, 2023 •
edited
Loading

I appreciate your input, @imsodin. @bt90, please inform me if this meets the requirements for the pull request.

bt90
bt90 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@bt90 bt90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Screenshot_20231011-070459~2

@githubashutoshsoni
Copy link
Contributor Author

lgtm

Waiting for @bt90's feedback before merging.

Thanks @bt90 for approving. Can this be merged now? @imsodin

@imsodin imsodin changed the title Add notification permission for api level 33 and above Add notification permission for api level 33 and above (fixes #1976) Oct 11, 2023
@imsodin imsodin changed the title Add notification permission for api level 33 and above (fixes #1976) Add notification permission for api level >=33 (fixes #1976) Oct 11, 2023
@imsodin imsodin merged commit 2ff421a into syncthing:main Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bt90 bt90 bt90 approved these changes

@imsodin imsodin imsodin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@githubashutoshsoni @bt90 @imsodin @ashutoshbitcot