Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PRNGFixes file #2036

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

adamszewe
Copy link
Contributor

The security workarounds contained in the PRNGFixes class were needed for devices older Android APIs (16, 17, 18) while the current min sdk API is 21.
Therefore this workaround is no longer needed.

@adamszewe adamszewe force-pushed the remove-prngfixes-workaround-file branch from 214ea46 to d954c44 Compare January 5, 2024 22:39
public static void apply() {
applyOpenSSLFix();
installLinuxPRNGSecureRandom();
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first method checks whether the SDK version is lower than 16 or higher than 18.
The second method checks only whether it's higher than 18.
The current min sdk version for the app is 21, thus the rest of the class is never executed.

@adamszewe adamszewe marked this pull request as ready for review January 5, 2024 22:49
@imsodin imsodin merged commit eb0e1d6 into syncthing:main Jan 7, 2024
1 check passed
imsodin pushed a commit that referenced this pull request Jan 7, 2024
Refactor code inside `if-else` blocks that checks for versions that are
no longer relevant.
Few lines could be deleted some others were just un-wrapped from the
if-else blocks.
The `if-else` blocks inside `PRNGFixes` file were left out as this file
is should be deleted in
#2036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants