Make banner for TV track compliant #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App is now rejected because of banner not filling the full page. Looks like our banner is not compliant with any standards that ever existed. Ok maybe it did, definitely not now. Also it looks weird - what's that background? Use adaptive shenanigans, created from the horizontal logo in the main repo assets. Sizing hopefully right, took a bunch of trial and error and ugly hacks to get there. Worst case the TV app launcher thing will look off. https://developer.android.com/design/ui/tv/guides/system/tv-app-icon-guidelines#adaptive-banner
AudriusButkevicius
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App was rejected because of banner not filling the full page. I already pushed these changes to the play store (via the release branch) to iterate on play reviews. This was likely accepted, as the tv banner rejection went away and now we are back to all file permission rejection. "Likely" because it's not unimaginable that they are just randomly ping-ponging between the two rejections.
Looks like our previous banner is not compliant with any standards that ever existed. Ok maybe it did, definitely not now. Also it looks weird - what's that background?
Use the adaptive icon guideline, created from the horizontal logo in the main repo assets. Sizing is hopefully right, it took a bunch of trial and error and ugly hacks to get there. Worst case the TV app launcher thing will look off.
https://developer.android.com/design/ui/tv/guides/system/tv-app-icon-guidelines#adaptive-banner