This repository has been archived by the owner on Jun 14, 2019. It is now read-only.
Changes to test ID framework to make things more efficient and simpler #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elvisisking
commented
May 28, 2019
elvisisking
commented
- see Please add ID/data-testid on every element requires user interaction #304
- test IDs are now hardcoded values unless they need to contain some user-defined text (like a name)
- modified the test ID convert function to match the angular codebase
- updated the readme
|
PR Storybook available here |
gashcrumb
previously approved these changes
May 29, 2019
|
Pull request approved by @gashcrumb - applying approved label |
- test IDs are now hardcoded values unless they need to contain some user-defined text (like a name) - modified the test ID convert function to match the angular codebase - updated the readme
|
PR Storybook available here |
gashcrumb
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.