Merge pull request #5844 from elvisisking/432

Fix toast notification for uploading extension shows ID
syndesisio · Jun 20, 2019 · 817b645 · 817b645
2 parents 0c03868 + 073ec1f
commit 817b645
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/app/ui-react/syndesis/src/modules/extensions/locales/extensions-translations.en.json b/app/ui-react/syndesis/src/modules/extensions/locales/extensions-translations.en.json
@@ -14,6 +14,7 @@
     "extensionImportPageTitle": "$t(extension.ImportExtension)",
     "extensionsPageDescription": "<p>Extensions provide custom features for use in integrations. Find out more at <a href=$t(shared:links.userguide) target=\"_blank\">$t(shared:project.name) Help</a>.</p>",
     "extensionsPageTitle": "$t(shared:Extensions)",
+    "extensionUploadSuccessMessage": "\"{{extensionName}}\" was successfully uploaded",
     "idMessage": "(ID: {{id}})",
     "importDndInstructions": "Drag and drop <strong>one</strong> file here, or <strong>click</strong> to select the file by using a file chooser dialog.",
     "ImportExtension": "$t(shared:Import) $t(shared:Extension)",

diff --git a/app/ui-react/syndesis/src/modules/extensions/locales/extensions-translations.it.json b/app/ui-react/syndesis/src/modules/extensions/locales/extensions-translations.it.json
@@ -14,6 +14,7 @@
     "extensionImportPageTitle": "$t(extension.ImportExtension)",
     "extensionsPageDescription": "<p>Le estensioni forniscono funzionalità personalizzate da utilizzare nelle integrazioni. Scopri di più su <a href=$t(shared:links.userguide) target=\"_blank\">$t(shared:project.name) Aiuto</a></p>.",
     "extensionsPageTitle": "$t(shared:Extensions)",
+    "extensionUploadSuccessMessage": "\"{{extensionName}}\" è stato caricato con successo",
     "idMessage": "(ID: {{id}})",
     "importDndInstructions": "Trascina qui <strong>uno</strong> file o <strong>fai clic </strong> per selezionare un file utilizzando una finestra di dialogo di selezione file.",
     "ImportExtension": "$t(shared:Extension) di $t(shared:Import)",

diff --git a/app/ui-react/syndesis/src/modules/extensions/pages/ExtensionImportPage.tsx b/app/ui-react/syndesis/src/modules/extensions/pages/ExtensionImportPage.tsx
@@ -132,7 +132,9 @@ export default class ExtensionImportPage extends React.Component<
                           : await uploadExtension(files[0]);
 
                         pushNotification(
-                          `${uploaded.id} was uploaded`,
+                          i18n.t('extensions:extension.extensionUploadSuccessMessage', {
+                            extensionName: uploaded.name,
+                          }),
                           'success'
                         );