Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code to run on Powersystem #342

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

genisysram
Copy link

Hi
Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

@genisysram
Copy link
Author

@qianbin
please merge my PR

@qianbin
Copy link
Contributor

qianbin commented Dec 10, 2020

@qianbin
please merge my PR

I'm sorry that i'v no privilege to merge PR.

@genisysram
Copy link
Author

@syndtr
Please merge my PR


go:
- 1.9.x
- 1.10.x
- 1.11.x
- tip
matrix:
allow_failures:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we allow failures?
Why test then?

Copy link

@tgulacsi tgulacsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does goleveldb gain by testing on ppc64le?
Has anything failed on that architecture?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants