fix(#1075): Populate accountid and role correctly for exec when using UI #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when using UI This fixes synfinatic#1075 by ensuring that the accountid and role used by the exec command for getting the DefaultRegion is correctly poplutade for both the commandline parameters and the interactive UI, rather than just the commandline parameters.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 35 35
Lines 3037 3037
=======================================
Hits 2564 2564
Misses 380 380
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1075 by ensuring that the accountid and role used by the exec command for getting the DefaultRegion is correctly poplutade for both the commandline parameters and the interactive UI, rather than just the commandline parameters.