Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locking around storage access #1113

Merged
merged 1 commit into from
Nov 30, 2024
Merged

add locking around storage access #1113

merged 1 commit into from
Nov 30, 2024

Conversation

synfinatic
Copy link
Owner

Refs: #1084

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (6ac9ae9) to head (6f5765a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
+ Coverage   83.21%   83.43%   +0.23%     
==========================================
  Files          35       36       +1     
  Lines        3816     3867      +51     
==========================================
+ Hits         3175     3226      +51     
  Misses        548      548              
  Partials       93       93              
Flag Coverage Δ
unittests 83.43% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/storage/flock.go 100.00% <100.00%> (ø)
internal/storage/keyring.go 93.44% <100.00%> (+0.76%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac9ae9...6f5765a. Read the comment docs.

@synfinatic synfinatic force-pushed the flock-keystore branch 3 times, most recently from 43b20d4 to 41966ab Compare November 30, 2024 01:13
@synfinatic synfinatic merged commit 7acfb43 into main Nov 30, 2024
7 checks passed
@synfinatic synfinatic deleted the flock-keystore branch November 30, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant