Continue work on login command #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- login is not needed for all commands.
- process command doesn't open URLs anymore so...
- Remove `--open` flag from `process` command
- Remove `ConfigProfilesUrlAction` config option
Refs: #291
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 84.19% 84.17% -0.02%
==========================================
Files 42 42
Lines 3074 3071 -3
==========================================
- Hits 2588 2585 -3
Misses 393 393
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
--url-action --sts-refresh also break up commands that require login from those that don't in help
synfinatic
force-pushed
the
login-only-needed
branch
from
a7b0955
to
1de4766
Compare
synfinatic
force-pushed
the
login-only-needed
branch
from
1de4766
to
84dfcf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--openflag fromprocesscommand - RemoveConfigProfilesUrlActionconfig optionRefs: #291