Stop using String names for LinkLayer/DLT types #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synfinatic
force-pushed
the
raw-dlt-fix
branch
3 times, most recently
from
a54f37f to
73d00c9
Compare
|
been holding off on merging this.... really should see if I can fix it upstream in gopacket. |
Ugh, this is even more complicated than I originally understood. So many abstraction layers! Honestly, I really don't understand the whole point of that. Anyways, I'm not sure if there is a "fix" upstream or what. May need to look at this from a different perspective. |
Finally understood what was going on... TL;DR: gopacket/layers.LinkType is kinda fubar because DLT != Linktype. For more context: https://www.tcpdump.org/linktypes.html Fixes #37
synfinatic
force-pushed
the
raw-dlt-fix
branch
from
73d00c9 to
8a7b671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally understood what was going on... TL;DR: gopacket/layers.LinkType
is kinda fubar because DLT != Linktype.
For more context: https://www.tcpdump.org/linktypes.html
Fixes #37