append new note if exist note on ThenComment.java #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if note not empty new note append to exist note
ddwightx
reviewed
Oct 9, 2024
| @@ -19,8 +19,16 @@ public RuleResponse perform(EventInfo eventInfo) { | |||
| boolean hasError = true; | |||
| try { | |||
| if (eventInfo.getAnnotations() != null) { | |||
| eventInfo.getAnnotations().setNotes(text.getText(eventInfo)); | |||
| hasError = false; | |||
| if (!eventInfo.getAnnotations().notes().isEmpty()) { | |||
There was a problem hiding this comment.
Thanks for the contribution!
I am concerned about changing the default functionality. A way to alleviate that is to add a boolean field (checkbox) labeled something like Append that would control whether or not to append or overwrite.
That being said, I actually think this solution isn't needed. Today in the Text field, instead of putting Hello World, you can put {{a:comment}}Hello World instead. If there wasn't already a comment the final comment will be Hello World. However, if there is a comment already, it will be <existing commment here>Hello World. What are your thoughts on that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is already a note, it will be append to the note.
Also, this feature has been added that if two triggers are activated on a request, the notes of both triggers are written on the request.
But before, only one trigger note was applied to each request.