fix ecs

synolia · Jul 26, 2021 · 8c82911 · 8c82911
1 parent 94a52a0
commit 8c82911
Show file tree

Hide file tree

Showing 109 changed files with 533 additions and 375 deletions.
diff --git a/ruleset/ecs.php b/ruleset/ecs.php
@@ -17,11 +17,14 @@
         dirname(__DIR__, 1) . '/spec',
     ]);
 
-    $parameters->set(Option::SETS, [
-        SetList::SYMFONY,
-        SetList::PHP_73_MIGRATION,
-        SetList::PHP_CS_FIXER,
-    ]);
+    $containerConfigurator->import(SetList::PSR_12);
+    $containerConfigurator->import(SetList::PHP_CS_FIXER);
+    $containerConfigurator->import(SetList::SYMFONY);
+    $containerConfigurator->import(SetList::SYMFONY_RISKY);
+    $containerConfigurator->import(SetList::DOCTRINE_ANNOTATIONS);
+    $containerConfigurator->import(SetList::ARRAY);
+    $containerConfigurator->import(SetList::CLEAN_CODE);
+
     $parameters->set(Option::SKIP, [
         PhpCsFixer\Fixer\Whitespace\MethodChainingIndentationFixer::class => [
             dirname(__DIR__, 1) . '/src/*/*Configuration*.php',

diff --git a/src/Builder/Attribute/MetricProductAttributeValueValueBuilder.php b/src/Builder/Attribute/MetricProductAttributeValueValueBuilder.php
@@ -34,6 +34,6 @@ public function support(string $attributeCode): bool
      */
     public function build(string $attributeCode, ?string $locale, ?string $scope, $value)
     {
-        return \trim(implode(' ', $value));
+        return trim(implode(' ', $value));
     }
 }
diff --git a/src/Builder/Attribute/MultiSelectProductAttributeValueValueBuilder.php b/src/Builder/Attribute/MultiSelectProductAttributeValueValueBuilder.php
@@ -36,7 +36,7 @@ public function support(string $attributeCode): bool
     public function build(string $attributeCode, ?string $locale, ?string $scope, $values)
     {
         foreach ($values as $key => $value) {
-            $values[$key] = CreateUpdateDeleteTask::AKENEO_PREFIX . $value;
+            $values[$key] = CreateUpdateDeleteTask::AKENEO_PREFIX.$value;
         }
 
         return $values;

diff --git a/src/Builder/Attribute/ReferenceEntityAttributeValueValueBuilder.php b/src/Builder/Attribute/ReferenceEntityAttributeValueValueBuilder.php
@@ -106,7 +106,7 @@ public function build(string $attributeCode, ?string $locale, ?string $scope, $v
                 MissingScopeException |
                 TranslationNotFoundException $exception
             ) {
-                $this->akeneoLogger->debug(\sprintf(
+                $this->akeneoLogger->debug(sprintf(
                     'Skipped attribute value "%s" for reference entity "%s" with value "%s" for locale "%s" and scope "%s"',
                     $subAttributeCode,
                     $referenceEntityAttributeProperties['reference_data_name'],

diff --git a/src/Builder/Attribute/SelectProductAttributeValueValueBuilder.php b/src/Builder/Attribute/SelectProductAttributeValueValueBuilder.php
@@ -35,6 +35,6 @@ public function support(string $attributeCode): bool
      */
     public function build(string $attributeCode, ?string $locale, ?string $scope, $value)
     {
-        return [CreateUpdateDeleteTask::AKENEO_PREFIX . $value];
+        return [CreateUpdateDeleteTask::AKENEO_PREFIX.$value];
     }
 }
diff --git a/src/Builder/Attribute/TextProductAttributeValueValueBuilder.php b/src/Builder/Attribute/TextProductAttributeValueValueBuilder.php
@@ -38,6 +38,6 @@ public function support(string $attributeCode): bool
      */
     public function build(string $attributeCode, ?string $locale, ?string $scope, $value)
     {
-        return \trim((string) $value);
+        return trim((string) $value);
     }
 }
diff --git a/src/Controller/AttributesController.php b/src/Controller/AttributesController.php
@@ -74,7 +74,9 @@ public function __invoke(Request $request): Response
         /** @var AttributeAkeneoSyliusMapping[] $attributeAkeneoSyliusMappings */
         $attributeAkeneoSyliusMappings = $this->attributeAkeneoSyliusMappingRepository->findAll();
 
-        $settings = ['import_referential_attributes' => SettingType::AKENEO_SETTINGS['import_referential_attributes']];
+        $settings = [
+            'import_referential_attributes' => SettingType::AKENEO_SETTINGS['import_referential_attributes'],
+        ];
         foreach ($settings as $key => $value) {
             $settings[$key] = $this->settingsManager->get($key);
         }
@@ -117,13 +119,13 @@ private function removeRemovedMappedItemsFromFormRequest(
         array $attributeAkeneoSyliusMappings
     ): void {
         foreach ($attributeTypeMappings as $attributeTypeMapping) {
-            if (false === \array_search($attributeTypeMapping, $attributes[AttributesTypeMappingType::ATTRIBUTE_TYPE_MAPPINGS_CODE], true)) {
+            if (false === array_search($attributeTypeMapping, $attributes[AttributesTypeMappingType::ATTRIBUTE_TYPE_MAPPINGS_CODE], true)) {
                 $this->entityManager->remove($attributeTypeMapping);
             }
         }
 
         foreach ($attributeAkeneoSyliusMappings as $attributeAkeneoSyliusMapping) {
-            if (false === \array_search($attributeAkeneoSyliusMapping, $attributes[AttributesTypeMappingType::ATTRIBUTE_AKENEO_SYLIUS_MAPPINGS_CODE], true)) {
+            if (false === array_search($attributeAkeneoSyliusMapping, $attributes[AttributesTypeMappingType::ATTRIBUTE_AKENEO_SYLIUS_MAPPINGS_CODE], true)) {
                 $this->entityManager->remove($attributeAkeneoSyliusMapping);
             }
         }

diff --git a/src/Controller/ProductsController.php b/src/Controller/ProductsController.php
@@ -90,7 +90,7 @@ private function removeElements(?Collection $productConfiguration, ?Collection $
         }
 
         foreach ($productConfiguration as $defaultTax) {
-            if (false === \array_search($defaultTax, $productConfigurationData->toArray(), true)) {
+            if (false === array_search($defaultTax, $productConfigurationData->toArray(), true)) {
                 $this->entityManager->remove($defaultTax);
             }
         }

diff --git a/src/DependencyInjection/Compiler/AkeneoAttributeTypeMatcherCompilerPass.php b/src/DependencyInjection/Compiler/AkeneoAttributeTypeMatcherCompilerPass.php
@@ -17,7 +17,7 @@ public function process(ContainerBuilder $container): void
         $definition = $container->getDefinition(AttributeTypeMatcher::class);
 
         $taggedServices = $container->findTaggedServiceIds(AttributeTypeMatcherInterface::TAG_ID);
-        foreach (\array_keys($taggedServices) as $id) {
+        foreach (array_keys($taggedServices) as $id) {
             $definition->addMethodCall('addTypeMatcher', [new Reference($id)]);
         }
     }

diff --git a/src/DependencyInjection/Compiler/AkeneoAttributeValueValueBuilderCompilerPass.php b/src/DependencyInjection/Compiler/AkeneoAttributeValueValueBuilderCompilerPass.php
@@ -17,7 +17,7 @@ public function process(ContainerBuilder $container): void
         $definition = $container->getDefinition(ProductAttributeValueValueBuilder::class);
 
         $taggedServices = $container->findTaggedServiceIds(ProductAttributeValueValueBuilderInterface::TAG_ID);
-        foreach (\array_keys($taggedServices) as $id) {
+        foreach (array_keys($taggedServices) as $id) {
             $definition->addMethodCall('addBuilder', [new Reference($id)]);
         }
     }

diff --git a/src/DependencyInjection/Compiler/AkeneoReferenceentityAttributeTypeMatcherCompilerPass.php b/src/DependencyInjection/Compiler/AkeneoReferenceentityAttributeTypeMatcherCompilerPass.php
@@ -17,7 +17,7 @@ public function process(ContainerBuilder $container): void
         $definition = $container->getDefinition(ReferenceEntityAttributeTypeMatcher::class);
 
         $taggedServices = $container->findTaggedServiceIds(ReferenceEntityAttributeTypeMatcherInterface::TAG_ID);
-        foreach (\array_keys($taggedServices) as $id) {
+        foreach (array_keys($taggedServices) as $id) {
             $definition->addMethodCall('addTypeMatcher', [new Reference($id)]);
         }
     }

diff --git a/src/DependencyInjection/Compiler/AkeneoTaskCompilerPass.php b/src/DependencyInjection/Compiler/AkeneoTaskCompilerPass.php
@@ -21,7 +21,7 @@ public function process(ContainerBuilder $container): void
         $definition = $container->getDefinition(AkeneoTaskProvider::class);
 
         $taggedServices = $container->findTaggedServiceIds(AkeneoTaskInterface::TAG_ID);
-        foreach (\array_keys($taggedServices) as $id) {
+        foreach (array_keys($taggedServices) as $id) {
             $definition->addMethodCall('addTask', [new Reference($id)]);
         }
     }

diff --git a/src/DependencyInjection/SynoliaSyliusAkeneoExtension.php b/src/DependencyInjection/SynoliaSyliusAkeneoExtension.php
@@ -20,23 +20,25 @@ final class SynoliaSyliusAkeneoExtension extends Extension implements PrependExt
      */
     public function load(array $config, ContainerBuilder $container): void
     {
-        $loader = new YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
+        $loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
 
         $loader->load('services.yaml');
     }
 
     public function prepend(ContainerBuilder $container): void
     {
-        $container->prependExtensionConfig('monolog', ['channels' => ['akeneo']]);
+        $container->prependExtensionConfig('monolog', [
+            'channels' => ['akeneo'],
+        ]);
 
         if (!$container->hasExtension('twig')) {
             return;
         }
 
-        $viewsPath = dirname(__DIR__) . '/Resources/views/';
+        $viewsPath = \dirname(__DIR__).'/Resources/views/';
         // This add our override in twig paths with correct namespace. No need for final user to copy it
         $paths = [
-            $viewsPath . 'SyliusAttributeBundle' => 'SyliusAttribute',
+            $viewsPath.'SyliusAttributeBundle' => 'SyliusAttribute',
         ];
 
         $container->prependExtensionConfig('twig', [

diff --git a/src/Entity/ApiConfiguration.php b/src/Entity/ApiConfiguration.php
@@ -53,8 +53,8 @@ class ApiConfiguration implements ResourceInterface
      * @var int
      * @ORM\Column(type="integer")
      * @Assert\Range(
-     *      min = ApiConfiguration::MIN_AKENEO_PAGINATION_SIZE,
-     *      max = ApiConfiguration::MAX_AKENEO_PAGINATION_SIZE,
+     *     min=ApiConfiguration::MIN_AKENEO_PAGINATION_SIZE,
+     *     max=ApiConfiguration::MAX_AKENEO_PAGINATION_SIZE,
      * )
      */
     private $paginationSize = self::DEFAULT_PAGINATION_SIZE;

diff --git a/src/Entity/ProductConfiguration.php b/src/Entity/ProductConfiguration.php
@@ -78,16 +78,16 @@ class ProductConfiguration implements ResourceInterface
 
     /**
      * @var bool
-     * @ORM\Column(name="enable_imported_products", type="boolean", options={"default" = 0})
+     * @ORM\Column(name="enable_imported_products", type="boolean", options={"default"=0})
      */
     private $enableImportedProducts = false;
 
     /**
      * @var ChannelInterface[]|Collection<int, ChannelInterface>
-     * @ORM\ManyToMany (targetEntity=ChannelInterface::class)
+     * @ORM\ManyToMany(targetEntity=ChannelInterface::class)
      * @ORM\JoinTable(name="akeneo_product_configuration_channels",
-     *      joinColumns={@ORM\JoinColumn(name="product_configuration_id", referencedColumnName="id")},
-     *      inverseJoinColumns={@ORM\JoinColumn(name="channel_id", referencedColumnName="id", unique=true)}
+     *     joinColumns={@ORM\JoinColumn(name="product_configuration_id", referencedColumnName="id")},
+     *     inverseJoinColumns={@ORM\JoinColumn(name="channel_id", referencedColumnName="id", unique=true)}
      * )
      */
     private $channelsToEnable;

diff --git a/src/Entity/ProductFiltersRules.php b/src/Entity/ProductFiltersRules.php
@@ -148,7 +148,7 @@ public function getLocales(): array
 
     public function addLocale(string $locale): self
     {
-        if (in_array($locale, $this->locales)) {
+        if (\in_array($locale, $this->locales)) {
             return $this;
         }
 
@@ -161,7 +161,7 @@ public function addLocale(string $locale): self
 
     public function removeLocale(string $locale): self
     {
-        if (!in_array($locale, $this->locales)) {
+        if (!\in_array($locale, $this->locales)) {
             return $this;
         }
 
@@ -251,7 +251,7 @@ public function getExcludeFamilies(): array
 
     public function addExcludeFamily(string $excludeFamily): self
     {
-        if (in_array($excludeFamily, $this->excludeFamilies)) {
+        if (\in_array($excludeFamily, $this->excludeFamilies)) {
             return $this;
         }
 
@@ -264,7 +264,7 @@ public function addExcludeFamily(string $excludeFamily): self
 
     public function removeExcludeFamily(string $excludeFamily): self
     {
-        if (!in_array($excludeFamily, $this->excludeFamilies)) {
+        if (!\in_array($excludeFamily, $this->excludeFamilies)) {
             return $this;
         }
 

diff --git a/src/Entity/ProductGroup.php b/src/Entity/ProductGroup.php
@@ -82,7 +82,7 @@ public function getVariationAxes(): array
 
     public function addVariationAxe(string $variationAxe): self
     {
-        if (in_array($variationAxe, $this->variationAxes)) {
+        if (\in_array($variationAxe, $this->variationAxes)) {
             return $this;
         }
 
@@ -93,7 +93,7 @@ public function addVariationAxe(string $variationAxe): self
 
     public function removeVariationAxe(string $variationAxe): self
     {
-        if (!in_array($variationAxe, $this->variationAxes)) {
+        if (!\in_array($variationAxe, $this->variationAxes)) {
             return $this;
         }
 

diff --git a/src/Filter/ProductFilter.php b/src/Filter/ProductFilter.php
@@ -65,7 +65,10 @@ public function getProductModelFilters(): array
 
             $queryParameters = $this->getExcludeFamiliesFilter($productFilterRules, $queryParameters);
             $queryParameters = $queryParameters->getFilters();
-            $queryParameters = ['search' => $queryParameters, 'scope' => $productFilterRules->getChannel()];
+            $queryParameters = [
+                'search' => $queryParameters,
+                'scope' => $productFilterRules->getChannel(),
+            ];
         }
 
         if (ProductFilterRuleAdvancedType::MODE === $productFilterRules->getMode() && !empty($productFilterRules->getAdvancedFilter())) {
@@ -98,7 +101,10 @@ public function getProductFilters(): array
             $queryParameters = $this->getExcludeFamiliesFilter($productFilterRules, $queryParameters);
             $queryParameters = $this->getStatus($productFilterRules, $queryParameters);
             $queryParameters = $queryParameters->getFilters();
-            $queryParameters = ['search' => $queryParameters, 'scope' => $productFilterRules->getChannel()];
+            $queryParameters = [
+                'search' => $queryParameters,
+                'scope' => $productFilterRules->getChannel(),
+            ];
         }
 
         if (ProductFilterRuleAdvancedType::MODE === $productFilterRules->getMode() && !empty($productFilterRules->getAdvancedFilter())) {
@@ -129,7 +135,7 @@ private function getAdvancedFilter(ProductFiltersRules $productFilterRules, bool
         }
 
         parse_str($productFilterRules->getAdvancedFilter(), $advancedFilter);
-        if (!array_key_exists('search', $advancedFilter)) {
+        if (!\array_key_exists('search', $advancedFilter)) {
             return $advancedFilter;
         }
 
@@ -155,10 +161,10 @@ private function getProductModelCompletenessTypeAdvancedFilter(array $filter): a
     private function getProductModelAdvancedFilter(array $advancedFilter): array
     {
         $advancedFilter['search'] = array_filter($advancedFilter['search'], static function (string $key): bool {
-            return in_array($key, self::AVAILABLE_PRODUCT_MODEL_QUERIES);
-        }, \ARRAY_FILTER_USE_KEY);
+            return \in_array($key, self::AVAILABLE_PRODUCT_MODEL_QUERIES);
+        }, ARRAY_FILTER_USE_KEY);
 
-        if (array_key_exists('completeness', $advancedFilter['search']) && is_array($advancedFilter['search']['completeness'])) {
+        if (\array_key_exists('completeness', $advancedFilter['search']) && \is_array($advancedFilter['search']['completeness'])) {
             $advancedFilter = $this->getProductModelCompletenessTypeAdvancedFilter($advancedFilter);
         }
 
@@ -218,7 +224,7 @@ private function getExcludeFamiliesFilter(ProductFiltersRules $productFilterRule
 
     private function getLocales(ProductFiltersRules $productFilterRules): array
     {
-        if (in_array($productFilterRules->getCompletenessType(), [
+        if (\in_array($productFilterRules->getCompletenessType(), [
             Operator::LOWER_THAN_ON_ALL_LOCALES,
             Operator::GREATER_THAN_ON_ALL_LOCALES,
             Operator::LOWER_OR_EQUALS_THAN_ON_ALL_LOCALES,
@@ -241,7 +247,7 @@ private function getCompletenessFilter(
             return $queryParameters;
         }
 
-        if (in_array($completenessType, [
+        if (\in_array($completenessType, [
             Operator::LOWER_THAN_ON_ALL_LOCALES,
             Operator::GREATER_THAN_ON_ALL_LOCALES,
             Operator::LOWER_OR_EQUALS_THAN_ON_ALL_LOCALES,
@@ -265,7 +271,7 @@ private function getCompletenessFilter(
             $completeness,
             $completenessValue,
             [
-                'locales' => in_array($completeness, [self::AT_LEAST_COMPLETE, self::ALL_COMPLETE]) ? $this->getLocales($productFilterRules) : [],
+                'locales' => \in_array($completeness, [self::AT_LEAST_COMPLETE, self::ALL_COMPLETE]) ? $this->getLocales($productFilterRules) : [],
                 'scope' => $productFilterRules->getChannel(),
             ]
         );

diff --git a/src/Form/DataTransformer/ReferenceEntityDataTransformer.php b/src/Form/DataTransformer/ReferenceEntityDataTransformer.php
@@ -11,7 +11,7 @@ class ReferenceEntityDataTransformer implements DataTransformerInterface
 {
     public function transform($value): string
     {
-        $json = \json_encode($value);
+        $json = json_encode($value);
 
         if (false === $json) {
             throw new ReferenceEntityTransformException('Could not transform reference entity array to json.');
@@ -22,6 +22,6 @@ public function transform($value): string
 
     public function reverseTransform($value): ?array
     {
-        return \json_decode($value, true);
+        return json_decode($value, true);
     }
 }
diff --git a/src/Form/Type/ApiConfigurationType.php b/src/Form/Type/ApiConfigurationType.php
@@ -47,11 +47,15 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 'label' => 'sylius.ui.admin.akeneo.api_configuration.is_enterprise',
             ])
             ->add('testCredentials', SubmitType::class, [
-                'attr' => ['class' => 'ui secondary button'],
+                'attr' => [
+                    'class' => 'ui secondary button',
+                ],
             ])
             ->add('submit', SubmitType::class, [
                 'label' => 'sylius.ui.save',
-                'attr' => ['class' => 'ui primary button'],
+                'attr' => [
+                    'class' => 'ui primary button',
+                ],
             ])
         ;
     }

diff --git a/src/Form/Type/AttributeCodeChoiceType.php b/src/Form/Type/AttributeCodeChoiceType.php
@@ -49,7 +49,7 @@ public function configureOptions(OptionsResolver $resolver): void
 
         $attributes = [];
         foreach ($attributePayload->getResources() as $attributeResource) {
-            $attributes[($attributeResource['labels'][$this->localeContext->getLocaleCode()]) ?? \current($attributeResource['labels'])] = $attributeResource['code'];
+            $attributes[($attributeResource['labels'][$this->localeContext->getLocaleCode()]) ?? current($attributeResource['labels'])] = $attributeResource['code'];
         }
 
         $resolver->setDefaults([

diff --git a/src/Form/Type/AttributeTypeChoiceType.php b/src/Form/Type/AttributeTypeChoiceType.php
@@ -23,7 +23,9 @@ public function __construct(array $attributeTypes)
      */
     public function configureOptions(OptionsResolver $resolver): void
     {
-        $resolver->setDefault('choices', array_merge($this->attributeTypes, ['multiselect' => 'multiselect']));
+        $resolver->setDefault('choices', array_merge($this->attributeTypes, [
+            'multiselect' => 'multiselect',
+        ]));
     }
 
     /**