feat: playlist order fix: #1622 #1629
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
w3cj
commented
Mar 29, 2024
| export const load = async function ({ locals }) { | ||
| const playlists = await locals.prisma.playlist.findMany({ | ||
| const playlistMeta = await locals.prisma.playlist.findMany({ |
There was a problem hiding this comment.
This is one of the questionable queries. Have to get all playlists first, then get each playlist in a separate query.
w3cj
commented
Mar 29, 2024
| }); | ||
| const playlists = await Promise.all( | ||
| playlistMeta.map(async (playlist) => { | ||
| return locals.prisma.playlist.findFirst({ |
There was a problem hiding this comment.
One query for every playlist... not ideal.
w3cj
commented
Mar 29, 2024
| export const load = async function ({ locals, params }) { | ||
| const { p_slug } = params; | ||
| const playlist = await locals.prisma.playlist.findUnique({ | ||
| const playlistMeta = await locals.prisma.playlist.findUnique({ |
There was a problem hiding this comment.
Same thing here, but for a single playlist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1622
Introduced a PlaylistOrder enum to the Playlist model. I thought this might be useful because some playlists we might want to keep ordering exactly as it is on YouTube, some should be reversed and some should be sorted by video published asc / desc.
If this is too complex we can just go with order by Video Published desc
This PR:
What needs review:
syntax-playlist-sort.mp4