Migrate to Svelte 5 #1866
Merged
Migrate to Svelte 5 #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 525.66kB (-1.58%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
|
All tests passing locally, svelte check all passing. |
|
For reviewers. It's a big pr, but since it was done using the migration assistant, doing smaller chunks was less possible. That said, all very smooth. I manually tested and ran playwrite / svelte check. |
|
Heyall. Speak now of forever hold your peace. |
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2024
* runs svelte 5 migration assistant * fixes migration tasks * 0 svelte check errors 2.1.166
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the migration assistant. Site loads. Will be bug hunting now.