New Start/Stop instance module for OVH Cloud Instances #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for this PR!
Another PR (#106) is opened covering the stop/start of public cloud instances amongst other things.
|
|
||
| DOCUMENTATION = """ | ||
| --- | ||
| module: public_cloud_instance_starting |
There was a problem hiding this comment.
Naming is hard, the module is not only managing start of instances. Maybe something like public_cloud_instance_manage_state
|
|
||
| EXAMPLES = r""" | ||
| - name: Start the instance | ||
| synthesio.ovh.public_cloud_instance_shelving: |
| route = f"/cloud/project/{service_name}/instance/{instance_id}/stop" | ||
| else: | ||
| module.fail_json(msg=f"On-Off state {onoff_state} is unknown", changed=False) | ||
|
|
There was a problem hiding this comment.
A check mode switch could be usefull here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good morning,
unfortunately it seems that a module that can start and stop OVH Cloud Instances is missing.
What I am referring is the OVH API Cloud
/cloud/project/{serviceName}/instance/{instanceId}/start(link here) and/cloud/project/{serviceName}/instance/{instanceId}/stop(link here).This module will be really needed and helpful for whoever desire to use your modules since it is not possible to start an instance otherwise.
I wrote that simple module called
plugins/modules/public_cloud_instance_starting.py, hoping you could accept it in your repo and hope I could help you and other people with my code.Thank you very much