Skip to content

Commit

Permalink
Merge pull request #95 from sysadminsmedia/katos/docker-healthcheck
Browse files Browse the repository at this point in the history
Update WGET from Busybox to APK
  • Loading branch information
katosdev authored Jul 7, 2024
2 parents 5c0d161 + 69e5a87 commit af1ab9d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
9 changes: 1 addition & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ FROM golang:alpine AS builder
ARG BUILD_TIME
ARG COMMIT
ARG VERSION
ARG BUSYBOX_VERSION=1.36.1-r31
RUN apk update && \
apk upgrade && \
apk add --update git build-base gcc g++
Expand All @@ -28,14 +27,8 @@ RUN CGO_ENABLED=0 GOOS=linux go build \
-o /go/bin/api \
-v ./app/api/*.go

# Downloading Wget
ADD https://busybox.net/downloads/binaries/$BUSYBOX_VERSION/busybox_WGET /wget
RUN chmod a+x /wget

FROM gcr.io/distroless/java:latest

COPY --from=builder /wget /usr/bin/wget

# Production Stage
FROM alpine:latest

Expand All @@ -46,9 +39,9 @@ ENV HBOX_STORAGE_SQLITE_URL=/data/homebox.db?_pragma=busy_timeout=2000&_pragma=j
RUN apk --no-cache add ca-certificates
RUN mkdir /app
COPY --from=builder /go/bin/api /app
COPY --from=builder /wget /usr/bin/wget

RUN chmod +x /app/api
RUN apk add --no-cache wget

LABEL Name=homebox Version=0.0.1
LABEL org.opencontainers.image.source="https://github.com/sysadminsmedia/homebox"
Expand Down
9 changes: 2 additions & 7 deletions Dockerfile.rootless
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,8 @@ RUN CGO_ENABLED=0 GOOS=linux go build \
# create a directory so that we can copy it in the next stage
mkdir /data

# Downloading Wget
ADD https://busybox.net/downloads/binaries/$BUSYBOX_VERSION/busybox_WGET /wget
RUN chmod a+x /wget

FROM gcr.io/distroless/java:latest

COPY --from=builder /wget /usr/bin/wget

# Production Stage
FROM gcr.io/distroless/static:latest

Expand All @@ -50,7 +44,8 @@ ENV HBOX_STORAGE_SQLITE_URL=/data/homebox.db?_fk=1
# change the ownership to the low-privileged user
COPY --from=builder --chown=nonroot /go/bin/api /app
COPY --from=builder --chown=nonroot /data /data
COPY --from=builder --chown=nonroot /wget /usr/bin/wget

RUN apk add --no-cache wget

LABEL Name=homebox Version=0.0.1
LABEL org.opencontainers.image.source="https://github.com/sysadminsmedia/homebox"
Expand Down

0 comments on commit af1ab9d

Please sign in to comment.