Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include authors fields in searchable text #161

Merged
merged 1 commit into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/recensio/plone/adapter/configure.zcml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@
name="listReviewAuthors"
/>

<adapter factory=".converters.AuthorsDexterityTextIndexFieldConverter" />

<adapter factory=".nextprevious.RecensioVolumeNextPrevious" />
<adapter factory=".nextprevious.RecensioIssueNextPrevious" />

Expand Down
26 changes: 26 additions & 0 deletions src/recensio/plone/adapter/converters.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
from plone.app.dexterity.textindexer.interfaces import IDexterityTextIndexFieldConverter
from recensio.plone.interfaces import IReview
from z3c.form.interfaces import IWidget
from z3c.relationfield.interfaces import IRelationList
from zope.component import adapter
from zope.interface import implementer


@implementer(IDexterityTextIndexFieldConverter)
@adapter(IReview, IRelationList, IWidget)
class AuthorsDexterityTextIndexFieldConverter:
"""Extract author names for indexing in SearchableText"""

def __init__(self, context, field, _):
"""Initialize field converter"""
self.context = context
self.field = field

def convert(self):
names = []
for relation in self.field.get(self.context):
obj = relation.to_object
if not obj:
continue
names.append(obj.title)
return ", ".join(names)
2 changes: 2 additions & 0 deletions src/recensio/plone/behaviors/authors.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from plone.app.dexterity.textindexer import searchable
from plone.app.vocabularies.catalog import CatalogSource
from plone.app.z3cform.widget import RelatedItemsFieldWidget
from plone.autoform import directives
Expand All @@ -20,6 +21,7 @@ class IAuthors(model.Schema):
RelatedItemsFieldWidget,
pattern_options={"mode": "auto", "favorites": []},
)
searchable("authors")
authors = RelationList(
title=_("Authors"),
defaultFactory=list,
Expand Down
1 change: 1 addition & 0 deletions src/recensio/plone/behaviors/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class IBase(model.Schema):
RelatedItemsFieldWidget,
pattern_options={"mode": "auto", "favorites": []},
)
searchable("reviewAuthors")
reviewAuthors = RelationList(
title=_("label_review_authors"),
defaultFactory=list,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<element value="plone.locking" />
<element value="plone.namefromtitle" />
<element value="plone.publication" />
<element value="plone.textindexer" />
<element value="recensio.article" />
<element value="recensio.authors" />
<element value="recensio.base" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<element value="plone.locking" />
<element value="plone.namefromtitle" />
<element value="plone.publication" />
<element value="plone.textindexer" />
<element value="recensio.article" />
<element value="recensio.authors" />
<element value="recensio.base" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<element value="plone.locking" />
<element value="plone.namefromtitle" />
<element value="plone.publication" />
<element value="plone.textindexer" />
<element value="recensio.base" />
<element value="recensio.base_review" />
<element value="recensio.licence" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<element value="plone.locking" />
<element value="plone.namefromtitle" />
<element value="plone.publication" />
<element value="plone.textindexer" />
<element value="recensio.base" />
<element value="recensio.base_review" />
<element value="recensio.cover_picture" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<element value="plone.locking" />
<element value="plone.namefromtitle" />
<element value="plone.publication" />
<element value="plone.textindexer" />
<element value="recensio.authors" />
<element value="recensio.base" />
<element value="recensio.base_review" />
Expand Down
Loading