Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PDF download #164

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix PDF download #164

merged 2 commits into from
Mar 1, 2024

Conversation

reinhardt
Copy link
Contributor

use blob file path, not file name attribute

syslabcom/scrum#1836

@reinhardt reinhardt requested a review from thet March 1, 2024 05:23
@reinhardt reinhardt changed the title Fix PDF generation Fix PDF download Mar 1, 2024
thet
thet approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@thet thet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, one comment suggestion derived from your PR comment.

src/recensio/plone/browser/pdfgen.py Show resolved Hide resolved
@reinhardt reinhardt merged commit b0bd750 into main Mar 1, 2024
3 checks passed
@reinhardt reinhardt deleted the scrum-1836-fix-pdf-download branch March 1, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thet thet thet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinhardt @thet