Improve MMIO read path interrupt updates #96
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
Hi @jserv , It may take some time but I will start to check whether this PR makes impact on For @shengwen-tw and @Mes0903 , |
jserv
force-pushed
the
improve-mmio
branch
2 times, most recently
from
56366c6 to
0d5ce34
Compare
This removes unnecessary interrupt update calls in mem_load() for non-interactive devices (PLIC, VirtIO-Net/Blk/RNG/Sound/FS, ACLINT MTIMER/MSWI/SSWI). Rationale: - MMIO read operations mostly query state without changing interrupt status - Can safely defer interrupt updates to periodic batch processing (every 64 cycles) - UART is exception due to interactive nature (read clears in_ready flag) - MMIO write operations trigger device actions and must update interrupts immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unnecessary interrupt update calls in mem_load() for non-interactive devices (PLIC, VirtIO-Net/Blk/RNG/Sound/FS, ACLINT MTIMER/MSWI/SSWI).
Rationale:
Summary by cubic
Removed interrupt updates from the MMIO read path for non-interactive devices and deferred them to periodic batch processing to reduce unnecessary work. UART reads remain immediate due to clearing the in_ready flag.