Refine the build system #200
Conversation
The top-level 'Makefile' unconditionally includes mk/{arm,riscv}.mk, and
the shell substitutions inside those two files run immediately even when
the active architecture is Arm.
That is why the "no qemu-riscv32 found" message appears during an Arm
build.
|
I also found another issue about the build system. If running $ make Q=
...
...
+out/shecc-stage1.elf -o out/shecc-stage2.elf src/main.c
...I think the above behavior is incorrect. Therefore, I referred to the changes in this pull request and create a patch to resolve the above issue. However, since my changes are very similar to this pull request, and I'm unsure whether the build system has other underlying issues, I provide my patch here for discussion first. Since my current work is related to the build system, I hope the above issue can at least be resolved soon. |
Alternatively, use |
The top-level 'Makefile' unconditionally includes mk/{arm,riscv}.mk, and the shell substitutions inside those two files run immediately even when the active architecture is Arm.
That is why the "no qemu-riscv32 found" message appears during an Arm build.
Summary by Bito
This pull request refines the build system by modifying the top-level Makefile to conditionally include architecture-specific files for ARM and RISC-V. This enhancement prevents unnecessary shell substitutions during builds for inactive architectures, improving the overall build process and error message clarity.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and primarily involve modifications to the Makefile, making the review process relatively simple.