feat(components): Add labelPosition prop on Switch #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch has a prop `label` to set its label. And its position is defaultly at the end. To put the label at the start of `Switch` is hard. So I add `labelPosition`, using `gap: 2` instead of the `mr: 2` to make sure that those children's space is right. By the way, I move those inner components outside, to make those code more clear than before. I hope that works.
Update its snapshot. It using `gap` rather than `margin` to set elements' space. And remove useless `span` label if the label is undefined.
Make the document more readable.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec31b71:
|
|
Hello, I finally rebase it to the current commit. It has been delayed over one more year. If you think it is OK, please merge it please. I have only some limited time for this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switchhas a prop label to set its label. And its position is default at the end. Putting the label at the start of Switch is hard.So I add
labelPosition, usinggap: 2instead of themr: 2to make sure that those children's space is right.Origin PR: #2137