Filter scale tuples in Theme type inside .sx prop #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a7330c:
|
hasparus
force-pushed
the
filter-scale-tuples
branch
from
6ed35d9 to
2f27f7b
Compare
hasparus
force-pushed
the
filter-scale-tuples
branch
from
4e70b1e to
e81549a
Compare
hasparus
force-pushed
the
filter-scale-tuples
branch
from
cc35b4f to
6f29731
Compare
|
I'm converting it to a draft, because userspace type narrowing thru declaration merging creates a breaking change for all projects that contain functions |
|
🚀 PR was released in |
This was referenced Sep 7, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2456.
Now the type of
themeinside ofsxprop doesn't contain array scales, so it should be easier to read from.We now also allow injecting the theme, but with a smaller blast radius than in #1090.