Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fast_{copy,set32} with native Rust #129

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

crawfxrd
Copy link
Member

Remove x86 specific logic implementing memcpy and memset, for functionality that is barely used to begin with.

Remove x86 specific logic implementing memcpy and memset, for
functionality that is barely used to begin with.

Signed-off-by: Tim Crawford <[email protected]>
@crawfxrd crawfxrd requested review from a team December 13, 2024 22:27
@crawfxrd crawfxrd marked this pull request as ready for review December 13, 2024 22:55
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on oryp12. Firmware update went smoothly.

@jackpot51 jackpot51 merged commit c7f7e89 into master Dec 19, 2024
2 checks passed
@jackpot51 jackpot51 deleted the memmove-memset branch December 19, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants